Handle plugin gracefully #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superstar54
force-pushed
the
handle_plugin_gracefully
branch
from
5dba081
to
703a71f
Compare
superstar54
force-pushed
the
handle_plugin_gracefully
branch
from
703a71f
to
86d646c
Compare
superstar54
force-pushed
the
handle_plugin_gracefully
branch
from
9227290
to
4b6cf45
Compare
|
Hi @AndresOrtegaGuerrero , I added a check for |
AndresOrtegaGuerrero
approved these changes
May 2, 2024
plugin_list.ipynb
Outdated
| " else:\n", | ||
| " # uninstall the package\n", | ||
| " message_container.value = f\"\"\"<div style=\"color: #FF0000;\">The plugin '{package_name}' was installed successfully but plugin functionality test failed: {result.stderr}. </div>\"\"\"\n", | ||
| " message_container.value += \"\"\"<div style=\"color: #FF0000;\">This may be due to compatibility issues with the current QEApp version. Please contact the plugin author for further assistance.</div>\"\"\"\n", |
There was a problem hiding this comment.
current AiiDAlab QEApp ?
There was a problem hiding this comment.
Thanks, I added AiiDAlab.
|
@AndresOrtegaGuerrero , thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to handle plugin gracefully in two ways:
qeapp-plugin-gracefully.mp4