馃憣 IMPROVE: Workflow summary #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbercx
force-pushed
the
67-fix-workflow_summary
branch
from
a18ca7d
to
f719c37
Compare
mbercx
force-pushed
the
67-fix-workflow_summary
branch
2 times, most recently
from
0022b4d
to
2b7c93b
Compare
Change the workflow summary to have two tables with the "WorkChain setings" and the "Advanced Settings". Fix several pieces in the code to make sure the output it obtained correctly. Also move to using jinja files and CSS to write down these somewhat larger HTML parts that can do with some styling.
mbercx
force-pushed
the
67-fix-workflow_summary
branch
from
2b7c93b
to
82bee7e
Compare
csadorf
approved these changes
Jun 11, 2021
Closed
|
@csadorf maybe have a peek before I merge ;) |
Closed
csadorf
suggested changes
Jun 11, 2021
csadorf
pushed a commit
that referenced
this pull request
Jul 14, 2021
Change the workflow summary to have two tables with the "WorkChain setings" and the "Advanced Settings". Fix several pieces in the code to make sure the output it obtained correctly. Other changes: * Move to using jinja files and CSS to write down these somewhat larger HTML parts that can do with some styling. * Add `isort` to the `pre-commit` config and have it play nice with `black`. * Switch to using builtin `importlib.resources` instead of the backport `importlib_resources`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57
Change the workflow summary to have two tables with the "WorkChain
setings" and the "Advanced Settings". Fix several pieces in the code to
make sure the output it obtained correctly.
Other changes:
larger HTML parts that can do with some styling.
isortto thepre-commitconfig and have it play nice withblack.importlib.resourcesinstead of the backportimportlib_resources.