StructureViewer Download tab: pass file format explicitly #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #504 +/- ##
=======================================
Coverage 79.42% 79.42%
=======================================
Files 27 27
Lines 3757 3757
=======================================
Hits 2984 2984
Misses 773 773
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
yakutovicha
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Thanks, @danielhollas - all good. I tested the changes locally and everything works fine 👍
And sorry for breaking your app 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #501 broke my application because it changed the
file_formattraitlet, on which I was relying.I could update my app but it would be a bit complicated to support both old and new version, so I thought I'll make a small change here if that is okay with you @yakutovicha.
Incidentally, I also fixed a small bug where
_prepare_payloadfunction was called twice.