-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move optimade dependency as extra dependency #554
Move optimade dependency as extra dependency #554
Conversation
Here is the attempt of moving optimade as an extra effort #554. I think we want it anyway. The test failed expect because the aiida-core is update to |
A real case in my mind is if the user have a workable AiiDAlab environment with |
0b4f5a1
to
94b4ba1
Compare
after #556 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #554 +/- ##
==========================================
- Coverage 87.16% 87.07% -0.09%
==========================================
Files 27 27
Lines 4642 4650 +8
==========================================
+ Hits 4046 4049 +3
- Misses 596 601 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e15be79
to
eeb9e15
Compare
eeb9e15
to
c5a14fa
Compare
Looking at the It would also make it easier for AiiDAlabs Apps to migrate to this package, since it would be more independent of the AWB version (e.g. one could switch to the new CC @yakutovicha might have more context here, as he was involved in a decision to move the widget here per #130 |
There's actually a long discussion about whether to include this OPTIMADE widget in AWB on this PR: I think we need to read through the arguments there and decide if they are still valid (especially given that we want to integrate AWB in the Docker image). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this moves us in the right direction so I think this is good to merge now and iterate on it.
@unkcpz just one request, could you please provide a screenshot of what happens when you try to load QeApp with this version but the optimade_client
package is not available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I wonder if more formatting would be warranted (e.g. maybe using the bootstrap error class or something like that to get a reddish box around it. Currently it's not immediately clear that it's an error.
Leaving that up to you.
290402e
to
f5ca2f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
be116cf
to
f5ca2f1
Compare
for more information, see https://pre-commit.ci
I quite like the appearance. I feel comfortable when the whole line filled, so I merge it ^^ |
No description provided.