Only trigger publish on release.published event #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
force-pushed
the
release-event
branch
from
2a2e253
to
702ba87
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #572 +/- ##
=======================================
Coverage 87.07% 87.07%
=======================================
Files 27 27
Lines 4649 4649
=======================================
Hits 4048 4048
Misses 601 601
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danielhollas
changed the title
unkcpz
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Looks all good, Thanks! @danielhollas
Now we have everything ready, can you write a wiki page for how to release. We can then ask Sasha to confirm with it and we can implement it to other packages as well.
|
Yep! On my todo-list for today or Wednesday. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that making a release triggered multiple different
releaseevents:created,prereleased,published. So we need to tweak the workflow file so that the workflow only run for therelease.publishevent.https://github.com/aiidalab/aiidalab-widgets-base/actions?query=event%3Arelease
Per GHA docs: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release
EDIT:
I am not sure if the fix here works, need to test on another repo. Marking as draft for nowEDIT2: Never mind, turns out I can't read the docs properly. I fixed the syntax and checked on my repo, this seems to work correctly now.