Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pandas as direct dependency #589

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

danielhollas
Copy link
Contributor

@danielhollas danielhollas commented Apr 28, 2024

pandas is used in several widgets to generate HTML tables. While the ultimate goal is to replace it with a lighterweight dependency, for now we declare it as direct dependecy. Previously, it was defined only transitively via optimade_client, which is now turned into optional optimade extras.

Closes #588

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (826ad43) to head (2d7033a).
Report is 4 commits behind head on master.

❗ Current head 2d7033a differs from pull request most recent head b90bf20. Consider uploading reports for the commit b90bf20 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
- Coverage   96.17%   96.04%   -0.13%     
==========================================
  Files          11       11              
  Lines        1177     1189      +12     
==========================================
+ Hits         1132     1142      +10     
- Misses         45       47       +2     
Flag Coverage Δ
python-3.10 96.04% <100.00%> (-0.13%) ⬇️
python-3.9 96.04% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@danielhollas danielhollas merged commit e56bb1e into aiidalab:master Apr 28, 2024
11 checks passed
@danielhollas danielhollas deleted the add-pandas branch April 28, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pandas as a dependency
2 participants