Test with aiida-core=2.5 #599
Conversation
danielhollas
commented
May 8, 2024
•
danielhollas
commented
- test aiida-core 2.5.1
- update test requirements
- squash some deprecations warnings
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #599 +/- ##
==========================================
- Coverage 96.21% 96.19% -0.02%
==========================================
Files 11 11
Lines 1188 1183 -5
==========================================
- Hits 1143 1138 -5
Misses 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| def fixture_localhost(aiida_localhost): | ||
| """Return a localhost `Computer`.""" | ||
| localhost = aiida_localhost | ||
| localhost.set_default_mpiprocs_per_machine(1) |
There was a problem hiding this comment.
I looked at the source code of the aiida_localhost fixture, and it seems to set this up by default, so I am not sure why this was here...
There was a problem hiding this comment.
I remember the fixture was directly copied from https://github.com/aiidateam/aiida-quantumespresso/blob/7b6c210a80942aed8ed08fa78f0d123d3227e750/tests/conftest.py#L42
Maybe it is not needed anymore? Then we can also remove it from aiida-quantumespresso.
There was a problem hiding this comment.
Ah, good to know, thanks. Looking at git blame, that fixture is five years old, so indeed most likely can be removed from there as well.
This reverts commit 7bce556.
|
Merging this since the changes here are low-risk and we want to start testing with 2.5. |
