Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of default computer in ComputationalResourcesDatabaseWidget #601

Merged
merged 2 commits into from
May 15, 2024

Conversation

yakutovicha
Copy link
Member

fixes #600

When the code is not present in the default machine it should still work.

When the code is not present in the default machine it should still work.
@yakutovicha yakutovicha requested a review from unkcpz May 14, 2024 13:29
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (9834dad) to head (3f342f0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #601   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files          11       11           
  Lines        1188     1188           
=======================================
  Hits         1143     1143           
  Misses         45       45           
Flag Coverage Δ
python-3.10 96.21% <ø> (ø)
python-3.9 96.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All good.

@yakutovicha yakutovicha merged commit e77ba92 into master May 15, 2024
12 checks passed
@yakutovicha yakutovicha deleted the fix/computational-resources-db-widget branch May 15, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in ComputationalResourcesDatabaseWidget
2 participants