Speedup readthedocs build with uv #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #604 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 11 11
Lines 1188 1188
=======================================
Hits 1143 1143
Misses 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yakutovicha
approved these changes
May 16, 2024
There was a problem hiding this comment.
Looks good to me, at least it is in sync with readthedocs/readthedocs.org#11322.
@unkcpz do you want to have a look?
|
Thanks @yakutovicha @unkcpz I've merged this, by you can still review this as part of #607 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I configured the readthedocs build to use
uvto install dependencies, according to readthedocs/readthedocs.org#11322This cuts the build time in half (by full minute!) so imo it's worth doing.