Check forked process calls for success during app installation.

aiidalab · Jul 27, 2022 · e706266 · e706266
1 parent faf8e78
commit e706266
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/aiidalab/utils.py b/aiidalab/utils.py
@@ -199,8 +199,9 @@ def this_or_only_subdir(path):
 
 
 def run_pip_install(*args, python_bin=sys.executable):
-    return subprocess.Popen(
+    return subprocess.check_call(
         [python_bin, "-m", "pip", "install", *args],
+        text=True,
         bufsize=1,
         stdout=subprocess.PIPE,
         stderr=subprocess.STDOUT,
@@ -217,16 +218,17 @@ def run_reentry_scan():
 
 
 def run_verdi_daemon_restart():
-    return subprocess.Popen(
+    return subprocess.check_call(
         ["verdi", "daemon", "restart"],
+        text=True,
         bufsize=1,
         stdout=subprocess.PIPE,
         stderr=subprocess.STDOUT,
     )
 
 
 def run_post_install_script(post_install_script_path):
-    return subprocess.Popen(
+    return subprocess.check_call(
         f"./{post_install_script_path.resolve().stem}",
         cwd=post_install_script_path.resolve().parent,
         stdout=subprocess.DEVNULL,