Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update instructions for local deployment to use aiidalab-launch. #256

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

csadorf
Copy link
Member

@csadorf csadorf commented Jan 20, 2022

No description provided.

Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csadorf
Copy link
Member Author

csadorf commented Jan 21, 2022

Ok, then let's merge this. Maybe in a future update we can make the "get started" paths a bit more akin as to how we present them in the AiiDA (core) docs. With panels and so on.

@csadorf
Copy link
Member Author

csadorf commented Jan 21, 2022

@ltalirz I primarily wanted to make you aware of this. Feel free to review after merge, we can still address any comments then.

@csadorf csadorf merged commit 75ec499 into aiidalab:main Jan 21, 2022
@csadorf csadorf deleted the docs/aiidalab-launch branch January 21, 2022 12:43
@ltalirz
Copy link
Member

ltalirz commented Jan 21, 2022

@ltalirz I primarily wanted to make you aware of this. Feel free to review after merge, we can still address any comments then.

Thanks @csadorf , I had a quick look and it looked good to me as well. Will open issues/PRs in case I encounter things that could be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants