Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.rst #275

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Update index.rst #275

merged 1 commit into from
Apr 12, 2022

Conversation

csadorf
Copy link
Member

@csadorf csadorf commented Apr 12, 2022

List aiidalab-launch before running the image manually.

@csadorf csadorf enabled auto-merge (squash) April 12, 2022 10:01
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csadorf thanks! Seems a minor indent bug fails the test.

docs/source/usage/index.rst Outdated Show resolved Hide resolved
@csadorf
Copy link
Member Author

csadorf commented Apr 12, 2022

@csadorf thanks! Seems a minor indent bug fails the test.

Hmm, not sure. I applied your suggestion and the indentation now seems off.

@unkcpz
Copy link
Member

unkcpz commented Apr 12, 2022

My bad, it should be an indent there in the second line. But not sure what caused the issue.

FYI, I quickly check the previous error message and it says /home/docs/checkouts/readthedocs.org/user_builds/aiidalab/checkouts/275/docs/source/usage/index.rst:25: WARNING: Bullet list ends without a blank line; unexpected unindent.

List aiidalab-launch before running the image manually.
@csadorf csadorf force-pushed the docs/prioritize-aiidalab-launch branch from b261c7f to 03b02c5 Compare April 12, 2022 13:33
@csadorf csadorf requested a review from unkcpz April 12, 2022 13:35
@csadorf
Copy link
Member Author

csadorf commented Apr 12, 2022

@unkcpz Should be fixed now.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csadorf thanks!

What happened explicitly that fail the test?

@csadorf csadorf merged commit 648148e into main Apr 12, 2022
@csadorf csadorf deleted the docs/prioritize-aiidalab-launch branch April 12, 2022 14:58
@csadorf
Copy link
Member Author

csadorf commented Apr 12, 2022

@csadorf thanks!

What happened explicitly that fail the test?

Not sure to be honest. I edited the file directly on my computer instead of the GitHub IDE and then everything was fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants