-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deps: Bump watchdog #328
Deps: Bump watchdog #328
Conversation
The old version prevents upgrade to Python 3.10 I checked the watchdog changelog and it seems this should be a seamless update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bump looks good to me. But I have no experience with this section of code. It also has no tests related. Could be good to run an installation to test it.
@yakutovicha could you give this a test? This is the only thing that's keeping us from migrating to Python 3.10, so I think we should go for it. Note that for testing this, if you want to download the image with Python 3.10 from ghcr.io, you will probably need to get a Github access token, that you then pass to Docker to authenticate. Alternatively, you can set the packages as public, I don't really see a downside to that (except possibly confusing people, who generally should always download from Dockerhub). |
Probably should be tested and merged after #346, although these PRs are unrelated. |
@unkcpz I have merged the
Images on ghcr.io are not public, so if you've never pulled from it, you need to first create a Github token for docker authentication, details described here: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry |
Thanks @danielhollas, I'll give it a test. |
Yes, the image is build in the CI automatically for each commit on that PR. |
Since @unkcpz is on it, I will remove myself from the reviewers. Please proceed without me here 👍 |
I give it a test and the issue report in #340 did not show. However, the https://aiidalab.github.io is down and the app-registry is broken. I 'll give it another test after @superstar54 fix it. |
I gave it a test again and all works fine. No |
Watchdog dependency seems to be used for live monitoring of AiiDAlab app installation process (I didn't look too closely what it actually does though). The old version prevents upgrade to Python 3.10.
I checked the watchdog Changelog and it seems this should be a seamless update. I have manually tested installation from the Appstore on this branch and it seems to work. Would be good if somebody else with more experience with Appstore tested as well. You can use this image:
ghcr.io/aiidalab/full-stack:pr-337
Note that this image is build with Python 3.10, so you might as well test other things. :-)