Fix base.html URLs #379
Fix base.html URLs #379
Conversation
Updated the URLs used in the footer of the application to use the correct links. Previously, the links were pointing to the wrong resources, but have been updated to point to the correct URLs. This includes updating the links to the AiiDAlab registry page in the aiidalab-registry repository. These changes ensure that users can access the correct resources from the footer of the application.
There was a problem hiding this comment.
thanks, @Mahhheshh. Could you also fix the links in: docs/source/conf.py and docs/source/usage/index.rst? They still point to the old AiiDAlab URL.
|
Yes, are there any additional links I'm missing? |
I think that is all. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
=======================================
Coverage 59.98% 59.98%
=======================================
Files 12 12
Lines 1122 1122
=======================================
Hits 673 673
Misses 449 449
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
docs/source/usage/index.rst
Outdated
| @@ -9,7 +9,7 @@ Access AiiDAlab | |||
|
|
|||
| As a user, you have three options to access AiiDAlab: | |||
|
|
|||
| 1. Log into one of the `open AiiDAlab servers <https://materialscloud.org/aiidalab>`_. | |||
| 1. Log into one of the `open AiiDAlab servers <https://www.aiidalab.net/>`_. | |||
There was a problem hiding this comment.
| 1. Log into one of the `open AiiDAlab servers <https://www.aiidalab.net/>`_. | |
| 1. Log into one of the `open AiiDAlab servers <https://www.aiidalab.net/deployments/>`_. |
Pipfile
Outdated
| @@ -0,0 +1,11 @@ | |||
| [[source]] | |||
There was a problem hiding this comment.
I don't think this file is needed.
There was a problem hiding this comment.
Sorry for that I will remove it
|
I guess I have messed up in hurry I will make another pull request sorry for in inconvenience, please close this one for now. |
This commit fixes the outdated links in `docs/source/conf.py` and `docs/source/usage/index.rst` that were pointing to the old AiiDAlab URL. The links have been updated to point to the new URL.
for more information, see https://pre-commit.ci
Looks all good now, thanks @Mahhheshh 👍 |
Solves #371
Updated the URLs used in the footer of the application to use the correct links. Previously, the links were pointing to the wrong resources, but have been updated to point to the correct URLs. This includes updating the links to the AiiDAlab registry page in the aiidalab-registry repository. These changes ensure that users can access the correct resources from the footer of the application.
This pull request fixes an issue in the parent file
base.htmlataiidalab/aiidalab/registry/templates/base.html
Line 3 in 50498b0
layout.htmlat https://github.com/aiidalab/aiidalab-registry/blob/8bc5d00fffa2016f562d065d81bd5a111c99479e/src/templates/layout.html#L8. The issue was causing variables to not be overwritten in the registry repository. The changes made in this pull request fix the links in the footer, and ensure that the variables can be correctly overwritten in the child file.