Switch to ruff linter and formatter #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
=======================================
Coverage 60.09% 60.09%
=======================================
Files 23 23
Lines 1466 1466
=======================================
Hits 881 881
Misses 585 585
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danielhollas
commented
Apr 3, 2024
| @@ -5,7 +5,7 @@ updates: | |||
| - package-ecosystem: github-actions | |||
| directory: / | |||
| schedule: | |||
| interval: daily | |||
| interval: monthly | |||
There was a problem hiding this comment.
This seems a bit saner and matches what we have in AWB.
danielhollas
commented
Apr 3, 2024
| except RuntimeError as inner_error: | ||
| logger.error(f"Rollback failed due to error: {inner_error}!") | ||
| except RuntimeError: | ||
| logger.exception("Rollback failed! Consider re-installing the app.") |
There was a problem hiding this comment.
Apparently, the exception is always automatically included when using logger.exception inside except statement.
danielhollas
commented
Apr 3, 2024
| @@ -121,7 +122,6 @@ def build( | |||
| api_path=base_path / api_path, | |||
| apps_index=apps_index, | |||
| apps_data=apps_data, | |||
| scan_app_repository=parse_app_repo, | |||
There was a problem hiding this comment.
This argument was completely unused in build_api_v1, perhaps copy-paste error or some historical remnant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've taken ruff config from AWB (with minor modifications as needed).