Update AEP 000: Add draft status
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltalirz
requested review from
csadorf,
sphuber,
giovannipizzi,
chrisjsewell and
greschd
ltalirz
force-pushed
the
issue_22_status_codes
branch
from
bbd29da
to
3e33b71
Compare
csadorf
suggested changes
Nov 2, 2020
Especially with larger projects it can take a significant amount of time (easily a couple of months) between first discussions on an enhancement proposal and its actual implementation/release in aiida-core. With the current approach, we have typically seen some initial discussion in a pull request, which then died at some point. Since there is no "checkpointing", when looking back at the PR after a long time, it can be unclear what was actually agreed upon and which questions were left open. Agreeing to merge the PR in a draft state provides such a checkpoint (besides making the draft more visible in the AEP repository). We also remove the 'submitted' status, since it was used only during the pull request stage and always needed to be changed before merging.
ltalirz
force-pushed
the
issue_22_status_codes
branch
from
3e33b71
to
9ca1a8e
Compare
Co-authored-by: Carl Simon Adorf <carl.simon.adorf@gmail.com>
|
Given that AEP 005 was already merged in I've accepted the suggestion by @csadorf for the description of the |
ltalirz
commented
Dec 16, 2021
csadorf
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
I'm going to approve this on the condition that the commit is cleaned up (@sphuber pointed out some artifacts). Other than that, I think this is fine as-is. I would recommend against adding the "date of modification" field, but I don't feel strongly about it and would find it more important that this PR is finally merged.
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
|
@sphuber Would you like to do a final check? |
sphuber
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22
Especially with larger projects it can take a significant amount of time
(easily a couple of months) between first discussions on an enhancement
proposal and its actual implementation/release in aiida-core. With the
current approach, we have typically seen some initial discussion in a
pull request, which then died at some point.
Since there is no "checkpointing", when looking back at the PR after a
long time, it can be unclear what was actually agreed upon and which
questions were left open. Agreeing to merge the PR in a draft state
provides such a checkpoint (besides making the draft more visible
in the AEP repository).
We also remove the 'submitted' status, since it was used only during
the pull request stage and always needed to be changed before merging.