-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AEP 000: Add draft
status
#23
Conversation
bbd29da
to
3e33b71
Compare
Especially with larger projects it can take a significant amount of time (easily a couple of months) between first discussions on an enhancement proposal and its actual implementation/release in aiida-core. With the current approach, we have typically seen some initial discussion in a pull request, which then died at some point. Since there is no "checkpointing", when looking back at the PR after a long time, it can be unclear what was actually agreed upon and which questions were left open. Agreeing to merge the PR in a draft state provides such a checkpoint (besides making the draft more visible in the AEP repository). We also remove the 'submitted' status, since it was used only during the pull request stage and always needed to be changed before merging.
3e33b71
to
9ca1a8e
Compare
Co-authored-by: Carl Simon Adorf <carl.simon.adorf@gmail.com>
Given that AEP 005 was already merged in I've accepted the suggestion by @csadorf for the description of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ltalirz , phrasing is fine for me. Just some small corrections to make and wondering if we should have a date that records day of merging the AEP, i.e., when it became accepted as a draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve this on the condition that the commit is cleaned up (@sphuber pointed out some artifacts). Other than that, I think this is fine as-is. I would recommend against adding the "date of modification" field, but I don't feel strongly about it and would find it more important that this PR is finally merged.
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
@sphuber Would you like to do a final check? |
Fixes #22
Especially with larger projects it can take a significant amount of time
(easily a couple of months) between first discussions on an enhancement
proposal and its actual implementation/release in aiida-core. With the
current approach, we have typically seen some initial discussion in a
pull request, which then died at some point.
Since there is no "checkpointing", when looking back at the PR after a
long time, it can be unclear what was actually agreed upon and which
questions were left open. Agreeing to merge the PR in a draft state
provides such a checkpoint (besides making the draft more visible
in the AEP repository).
We also remove the 'submitted' status, since it was used only during
the pull request stage and always needed to be changed before merging.