Get rid of vestigial leading underscores for non-storable inputs #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old convention to mark Process inputs as non database storable was to name them with a leading underscore. Now there is a proper mixin WithNonDb that is mixed into the InputPort and PortNamespace classes, which adds the attribute non_db, which can be used to mark a port as storable or non storable. We remove the underscores from the predefined Process and Workchain inputs * _options * _label * _description * _store_provenance Workchain implementations and JobProcess submissions by users will have to be updated to remove these leading underscored from the input dictionaries as well
sphuber
force-pushed
the
fix_1101_nuke_leading_underscore_convention
branch
from
1a00641
to
bf09099
Compare
sphuber
changed the title
muhrin
approved these changes
Feb 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1101
The old convention to mark
Processinputs as non database storablewas to name them with a leading underscore. Now there is a proper
mixin
WithNonDbthat is mixed into theInputPortandPortNamespaceclasses, which adds the attribute
non_db, which can be used tomark a port as storable or non storable. We remove the underscores
from the predefined
ProcessandWorkchaininputs_options_label_description_store_provenanceWorkchainimplementations andJobProcesssubmissions by users willhave to be updated to remove these leading underscored from the
input dictionaries as well