Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New daemon CLI with circus #1213

Closed
wants to merge 6 commits into from
Closed

New daemon CLI with circus #1213

wants to merge 6 commits into from

Conversation

DropD
Copy link
Contributor

@DropD DropD commented Mar 2, 2018

Fix #1055

What is not done:

  • Automated tests for the cli
  • The new cli is not used in the daemon test
  • I did not test actually submitting to daemons for multiple profiles simultaneously

Reviewers (@muhrin, @sphuber): please advise on whether to make tests into a separate issue & PR or to push into this one.

PS: It is really a shame that Aida has no deamon characters (or at least I don't remember any).

@DropD DropD requested review from muhrin and sphuber March 2, 2018 11:40
@sphuber sphuber mentioned this pull request Mar 3, 2018
Merged
@sphuber
Copy link
Contributor

sphuber commented Mar 7, 2018

Closed in favor of PR #1217

@sphuber sphuber closed this Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhrin muhrin Awaiting requested review from muhrin

@sphuber sphuber Awaiting requested review from sphuber

Assignees

@sphuber sphuber

Labels
priority/important topic/daemon topic/workflows type/accepted feature approved feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DropD @sphuber