Update reentry to v1.2.0 for release branch #1440
Conversation
Codecov Report
@@ Coverage Diff @@
## release_v0.12.0 #1440 +/- ##
================================================
Coverage 54.42% 54.42%
================================================
Files 246 246
Lines 32440 32440
================================================
Hits 17655 17655
Misses 14785 14785Continue to review full report at Codecov.
|
|
I can temporarily lift the setting that rebasing or adding more commits renders the approval stale, so then reapproval is not necessary. Regarding the Also, we still need to make sure that this alpha version fixes the problem in all relevant environments. I made a list in the issue #1429 . I know you use conda, could you please verify that this branch works with conda? |
|
@sphuber Rico asked me to check out reentry with conda a few hours ago and it seemed to work (i.e. data plugin registered by aiida-siesta became available after |
|
I asked for the REENTRY_PINNED variable (or any equivalent mechanism) because the version of reentry has to be specified in two different locations. It has nothing to do with this issue, so I would advise to keep it. @sphuber did you have a chance to check if this fixes also the Workflows branch? |
|
@giovannipizzi yes, you can check the issue #1429 where I added a list of checkboxes of environments that I have tested. We are just missing the check for both branches on Mac OS X. Could you maybe give a quick look to that on your machine? |
Starting `v10.0.0`, pip supports PEP 518 through the `pyproject.toml` file, which can be used to define dependencies that are required by the build process. We chose to use this mechanism over the `setup_requires` keyword in the `setup` call of `setup.py`, because that causes problems on older standard python version on Mac OS X as that goes through setuptools instead of pip. To ensure that the version of `reentry` specified in the `pyproject.toml` and the `setup_requirements.py`, I also add a pre-commit test.
sphuber
force-pushed
the
fix_1429_reentry_version_release_branch
branch
3 times, most recently
from
12e796e
to
c72ebf5
Compare
The new build procedure employing the pyproject.toml file relies on pip being at least v10.0.0, so we test that this requirement is satisfied in the setup.py or exit with a warning
sphuber
force-pushed
the
fix_1429_reentry_version_release_branch
branch
from
c72ebf5
to
5f46591
Compare
Fixes #1429
Update reentry to v1.2.0 which fixes the issue with entry points not being registered.
This currently contains the alpha release
v1.2.0a9, but once it is confirmed to workin all relevant environments and branches the actual version
v1.2.0will be releasedand I will update this PR with the actual release