Enable use of tuple in QueryBuilder.append for all ORM classes #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(Group,) which created a list of Nones for the query_type_string. This was resolved by explicitly checking that ormclass is a Node.
Codecov Report
@@ Coverage Diff @@
## develop #1608 +/- ##
========================================
Coverage 57.14% 57.14%
========================================
Files 273 273
Lines 33773 33773
========================================
Hits 19300 19300
Misses 14473 14473
Continue to review full report at Codecov.
|
lekah
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1398 was fixed in a previous commit to allow adding a tuple of classes to the
QueryBuilderthrough the
appendmethod, but it did not work for all ORM classes e.g.Group.This commit fixes the problem and enables the new approach for all ORM classes.