Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleteing dead code #1702

Merged

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Jun 28, 2018

fix #1692

@ltalirz ltalirz requested a review from sphuber June 28, 2018 15:21
@codecov-io
Copy link

Codecov Report

Merging #1702 into release_v0.12.2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           release_v0.12.2    #1702   +/-   ##
================================================
  Coverage            54.65%   54.65%           
================================================
  Files                  246      246           
  Lines                32423    32423           
================================================
  Hits                 17721    17721           
  Misses               14702    14702

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea76a50...22bfe07. Read the comment docs.

@ltalirz
Copy link
Member Author

ltalirz commented Jun 28, 2018

really strange that this doesn't affect coverage...
Edit: Ok, it's outside the monitored aiida folder

@sphuber
Copy link
Contributor

sphuber commented Jun 28, 2018

Does it skip the file because it is outside the aiida module? Is it excluded somehow?

@sphuber sphuber merged commit abee51f into aiidateam:release_v0.12.2 Jun 28, 2018
@ltalirz ltalirz deleted the issue_1692_remove_dead_code branch August 28, 2018 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants