Ensure that WorkChain._do_step return None, int or ExitCode #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case where the return value of the stepper was not of type None, int or ExitCode, yet the stepper considered itself to be finished, for example when the last step was executed, the return value of the stepper would be returned, which could have any type. However, the result of _do_step should only be an exit status, i.e. int or ExitCode. To fix this, we explicitly check the return value of the stepper and convert any type other than int or ExitCode to None.
Codecov Report
@@ Coverage Diff @@
## develop #1704 +/- ##
===========================================
+ Coverage 57.14% 57.15% +<.01%
===========================================
Files 275 275
Lines 33931 33931
===========================================
+ Hits 19390 19393 +3
+ Misses 14541 14538 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1693
In the case where the return value of the stepper was not of type
None, int or ExitCode, yet the stepper considered itself to be finished,
for example when the last step was executed, the return value of the
stepper would be returned, which could have any type. However, the
result of _do_step should only be an exit status, i.e. int or ExitCode.
To fix this, we explicitly check the return value of the stepper and
convert any type other than int or ExitCode to None.