Restore copy behavior #1752
Merged
Restore copy behavior #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release_v0.12.2 #1752 +/- ##
===================================================
+ Coverage 54.65% 54.67% +0.01%
===================================================
Files 246 246
Lines 32421 32432 +11
===================================================
+ Hits 17720 17731 +11
Misses 14701 14701
Continue to review full report at Codecov.
|
giovannipizzi
approved these changes
Jul 16, 2018
|
This correctly reverts #1746 and applies the correct fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache folder issue is fixed by explicitly copying the
copycode into the_store_from_cachedmethod. This isn't very nice, but since it's only the backport of the fix I think it's acceptable.