Converted Log to new backend system #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
muhrin
commented
Nov 21, 2018
muhrin
commented
- Removed custom Log find methods. These are piped through to the QueryBuilder now
- Temporarily adding dblog dummy model (can be removed once spyros finishes with the aldjemy work)
sphuber
reviewed
Nov 21, 2018
aiida/plugins/entry.py
Outdated
| @@ -80,21 +80,21 @@ def entry_points(self): | |||
| if not self._entry_points: | |||
| for category in self.entry_point_categories: | |||
| key = 'aiida.' + category | |||
| ep_list = [i[:i.find('=')].strip() for i in self.entry_points_raw[key]] | |||
| ep_list = [i[:i.find()].strip() for i in self.entry_points_raw[key]] | |||
There was a problem hiding this comment.
Did you remove these '=' from the find() call intentionally?
There was a problem hiding this comment.
Whoops, no, that was a search-replace mistake. I found a couple of others and reverted.
* Removed custom Log find methods. These are piped through to the QueryBuilder now * Temporarily adding dblog dummy model
muhrin
force-pushed
the
orm_log_refactor
branch
from
1c3157b
to
14ef6e6
Compare
sphuber
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.