Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure QueryBuilder return frontend entity of DbLog and DbComment #2325

Merged
merged 1 commit into from
Dec 8, 2018
Merged

Ensure QueryBuilder return frontend entity of DbLog and DbComment #2325

merged 1 commit into from
Dec 8, 2018

Conversation

muhrin
Copy link
Contributor

@muhrin muhrin commented Dec 7, 2018 •
edited by sphuber
Loading

Fixes #2321

@muhrin muhrin requested a review from szoupanos December 7, 2018 15:34
@muhrin muhrin changed the title Fixes #2321 DbLog and DbComment not being converted to ORM by QueryBuilder [BLOCKED] Fixes #2321 DbLog and DbComment not being converted to ORM by QueryBuilder Dec 7, 2018
@muhrin @sphuber
Ensure QueryBuilder return frontend entity of DbLog and DbComment
e61dca7 
Also moved a couple of modules to be plurals, namely `logs` and `comments`
@sphuber sphuber force-pushed the fix_2321_db_log_orm_conversion branch from dd5193c to e61dca7 Compare December 8, 2018 11:35
@sphuber sphuber changed the title [BLOCKED] Fixes #2321 DbLog and DbComment not being converted to ORM by QueryBuilder Ensure QueryBuilder return frontend entity of DbLog and DbComment Dec 8, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 68.962% when pulling e61dca7 on muhrin:fix_2321_db_log_orm_conversion into ada95a1 on aiidateam:provenance_redesign.

sphuber
sphuber approved these changes Dec 8, 2018
View reviewed changes
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An absolute blinder

@sphuber sphuber merged commit a64d5c1 into aiidateam:provenance_redesign Dec 8, 2018
@sphuber sphuber mentioned this pull request Dec 8, 2018
Closed
@muhrin muhrin deleted the fix_2321_db_log_orm_conversion branch December 12, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphuber sphuber sphuber approved these changes

@szoupanos szoupanos Awaiting requested review from szoupanos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muhrin @coveralls @sphuber