Make various protected Node methods public
#2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix_2538_wrongly_protected_methods
branch
2 times, most recently
from
c63b67d
to
dcc2302
Compare
These methods are intended to be called from outside the class hierarchy but were made protected (by prefixing them with an underscore) merely to hide them from auto-completion and signal to users that they should not be called by the user. However, this is the wrong usage of this feature and methods that should be callable from the outside should not be protected.
sphuber
force-pushed
the
fix_2538_wrongly_protected_methods
branch
from
dcc2302
to
b66b98f
Compare
giovannipizzi
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2538
These methods are intended to be called from outside the class hierarchy
but were made protected (by prefixing them with an underscore) merely to
hide them from auto-completion and signal to users that they should not
be called by the user. However, this is the wrong usage of this feature
and methods that should be callable from the outside should not be
protected.