Prevent launching or construction of WorkChain and CalcJob base class
#2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| run_and_check_success(Wf) | ||
| # def test_run(self): |
There was a problem hiding this comment.
Is this huge number of lines replaced with comments expected?
There was a problem hiding this comment.
No, I forgot to uncomment, I will fix it
sphuber
force-pushed
the
fix_2493_prevent_base_process_classes_submit
branch
from
57beac6
to
0cefc70
Compare
giovannipizzi
approved these changes
Mar 4, 2019
|
I canceled them since I will have to rebase this anyway after the others are merged, and so I am not blocking the build queue |
…lass The `WorkChain` and `CalcJob` classes are base classes that are meant to be sub classed as they miss the necessary functionality to successfully run. However, it was still possible to launch these base classes through the launchers or straight up constructing them. They would immediately fail when launched, but they would create a node in the provenance graph nonetheless. To prevent this from happening, a check is placed in the constructors to make sure that it is actually a sub class that is being constructed.
sphuber
force-pushed
the
fix_2493_prevent_base_process_classes_submit
branch
from
0cefc70
to
cc02f2b
Compare
This was referenced Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2493 and fixes #2474
The
WorkChainandCalcJobclasses are base classes that are meant tobe sub classed as they miss the necessary functionality to successfully
run. However, it was still possible to launch these base classes through
the launchers or straight up constructing them. They would immediately
fail when launched, but they would create a node in the provenance graph
nonetheless. To prevent this from happening, a check is placed in the
constructors to make sure that it is actually a sub class that is being
constructed.