Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise InvalidOperation for global submit in nested process #2781

Merged

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Apr 18, 2019

Fixes #2780

If one wants to submit another process from within a process, the
submit method of the parent process instance should be used instead of
the global launch function, which will guarantee the correct runner is
used.

If one wants to submit another process from within a process, the
`submit` method of the parent process instance should be used instead of
the global launch function, which will guarantee the correct runner is
used.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 71.627% when pulling 38b8a55 on sphuber:fix_2780_raise_global_submit_nested_process into e1b858d on aiidateam:develop.

Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@sphuber sphuber merged commit bcc95f2 into aiidateam:develop Apr 22, 2019
@sphuber sphuber deleted the fix_2780_raise_global_submit_nested_process branch April 22, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not allow use of top-level submit in scope of other process
3 participants