Automatically set CalcInfo.uuid in CalcJob.run
#2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannipizzi
approved these changes
May 14, 2019
The `uuid` field in the `CalcInfo` data structure which is built and returned by the `CalcJob.prepare_for_submission` implementation, is used subsequently by the engine to create the remote working directory. Previously, the implementer of `prepare_for_submission` was required to set it, but this always boiled down to setting it to the UUID of the process node. Since this is the only behavior that should happen anyway, we might as well have the engine take care of this, making the implementation of the `prepare_for_submission` for plugins simpler.
sphuber
force-pushed
the
fix_2872_automatically_set_calcinfo_uuid
branch
from
d58fb18
to
c7f23fb
Compare
unkcpz
pushed a commit
to unkcpz/aiida-core
that referenced
this pull request
May 20, 2019
The `uuid` field in the `CalcInfo` data structure which is built and returned by the `CalcJob.prepare_for_submission` implementation, is used subsequently by the engine to create the remote working directory. Previously, the implementer of `prepare_for_submission` was required to set it, but this always boiled down to setting it to the UUID of the process node. Since this is the only behavior that should happen anyway, we might as well have the engine take care of this, making the implementation of the `prepare_for_submission` for plugins simpler.
unkcpz
pushed a commit
to unkcpz/aiida-core
that referenced
this pull request
May 20, 2019
The `uuid` field in the `CalcInfo` data structure which is built and returned by the `CalcJob.prepare_for_submission` implementation, is used subsequently by the engine to create the remote working directory. Previously, the implementer of `prepare_for_submission` was required to set it, but this always boiled down to setting it to the UUID of the process node. Since this is the only behavior that should happen anyway, we might as well have the engine take care of this, making the implementation of the `prepare_for_submission` for plugins simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2872
The
uuidfield in theCalcInfodata structure which is built andreturned by the
CalcJob.prepare_for_submissionimplementation, is usedsubsequently by the engine to create the remote working directory.
Previously, the implementer of
prepare_for_submissionwas required toset it, but this always boiled down to setting it to the UUID of the
process node. Since this is the only behavior that should happen anyway,
we might as well have the engine take care of this, making the
implementation of the
prepare_for_submissionfor plugins simpler.