-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop the nodeversion
and public
columns of DbNode
#2937
Drop the nodeversion
and public
columns of DbNode
#2937
Conversation
Coverage decreased (-3.4%) to 69.312% when pulling 5aaae84be9dead35d155bfe6aa9b751cbf297950 on sphuber:fix_2925_drop_node_version_public into fbfabe8 on aiidateam:develop. |
# self.node.delete_extra(extra_name) | ||
|
||
# with self.assertRaises(AttributeError): | ||
# self.node.get_extra(extra_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these commented out by mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
5aaae84
to
8140933
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
These columns have been there from the initial model definition but have not been used at all. The adaptation of the import export format will be taken care of in another commit, that takes all the changes since v0.3 into account in one go.
8140933
to
a7a624e
Compare
Fixes #2925
These columns have been there from the initial model definition but have
not been used at all. The adaptation of the import export format will be
taken care of in another commit, that takes all the changes since v0.3
into account in one go.