Simplify the User database model by dropping unused columns
#2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can make use of the reusable components of the `verdi` command line module.
The following columns are dropped: * `password` * `date_joined` * `groups` * `is_active` * `is_staff` * `is_superuser` * `last_login` * `user_permissions` These columns were originally added because the base user class of the Django framework was used, which provided the ORM layer. However, these attributes are not used at all and Django does not require them in order to work properly. Therefore, we remove them from the models for both backends. Note that in principle, the `contrib` and `auth` applications currently installed for Django, could also be removed without affecting the functionality of `aiida-core` since it no longer requires the built in authentication application of Django. However, since the initial migration schema still references it, we cannot yet remove it fully. If we were to reset the database migration schema, we could get rid of these unnecessary dependencies.
sphuber
force-pushed
the
fix_2928_simplify_user_schema
branch
from
799bbea
to
c0caf74
Compare
giovannipizzi
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2928
The following columns are dropped:
passworddate_joinedgroupsis_activeis_staffis_superuserlast_loginuser_permissionsThese columns were originally added because the base user class of the
Django framework was used, which provided the ORM layer. However, these
attributes are not used at all and Django does not require them in order
to work properly. Therefore, we remove them from the models for both
backends.
Note that in principle, the
contribandauthapplications currentlyinstalled for Django, could also be removed without affecting the
functionality of
aiida-coresince it no longer requires the built inauthentication application of Django. However, since the initial
migration schema still references it, we cannot yet remove it fully.
If we were to reset the database migration schema, we could get rid of
these unnecessary dependencies.