Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to configure from yml file for verdi computer configure #2951

Merged
merged 1 commit into from
May 31, 2019
Merged

Add option to configure from yml file for verdi computer configure #2951

merged 1 commit into from
May 31, 2019

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented May 30, 2019

Fixes #2916

@sphuber sphuber requested a review from ltalirz May 30, 2019 20:30
@coveralls
Copy link

Coverage Status

Coverage increased (+6.03%) to 72.837% when pulling 2963978 on sphuber:fix_2916_verdi_computer_configure_from_config into 04e80d2 on aiidateam:develop.

ltalirz
ltalirz approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sphuber !

@sphuber sphuber merged commit 24b869b into aiidateam:develop May 31, 2019
@sphuber sphuber deleted the fix_2916_verdi_computer_configure_from_config branch May 31, 2019 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltalirz ltalirz ltalirz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to configure computer using a config.yml
3 participants
@sphuber @coveralls @ltalirz