Enforcing specific precision in clean_value for floats #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannipizzi
force-pushed
the
fix_2631_float_hash
branch
from
d5ea42d
to
b2a02de
Compare
This will guarantee a larger uniformity in what gets stored across backends. This fixes aiidateam#2631 Note that this commit also fixes the problem of the bigint vs. float part of the discussion that is mentioned in the thread, i.e. that numbers like 1.2e20, floats in python, become long ints in the database. Here we forcefully convert numbers >=1.e14 to integers to alleviate the problem and ensure that a roundtrip via the database does not change the hash. IMPORTANT: in this commit, we enforce a maximum precision of 14 digits in AiiDA - this is a change with respect to what used to be before. Note also that we are *not* going to truncate old AiiDA values, so behavior before and after this commit will change even if the stored value is the same. Note that this commit changes the hashing functionality, so we will need to ask users to rehash everything.
giovannipizzi
force-pushed
the
fix_2631_float_hash
branch
from
b2a02de
to
1acc7b1
Compare
|
Tests added in a second commit; also removed annoying output during tests of migrations |
Also, capturing output during migrations to avoid seeing warning messages (e.g. to rerun 'verdi rehash')
giovannipizzi
force-pushed
the
fix_2631_float_hash
branch
from
1acc7b1
to
b4ba1c5
Compare
sphuber
approved these changes
Jul 2, 2019
Merged
|
for the record: converting floats to string and back again to control decimal rounding/truncation seems to be a very efficient way to do it, see discussion here https://news.ycombinator.com/item?id=20816827 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2631
This will guarantee a larger uniformity in what gets stored across backends.
Note that this commit also fixes the problem of the bigint vs. float
part of the discussion that is mentioned in the thread, i.e.
that numbers like 1.2e20, floats in python, become long ints
in the database. Here we forcefully convert numbers >=1.e14 to
integers to alleviate the problem and ensure that a roundtrip
via the database does not change the hash.
IMPORTANT: in this commit, we enforce a maximum precision of 14
digits in AiiDA - this is a change with respect to what used
to be before. Note also that we are not going to truncate old
AiiDA values, so behavior before and after this commit will change
even if the stored value is the same.
Note that this commit changes the hashing functionality, so we
will need to ask users to rehash everything.