Move unit tests from aiida to top-level tests
#3715
Conversation
There was a problem hiding this comment.
thanks @sphuber for making progress with this!
If you look at the travis logs, you'll notice that it is actually not yet running the tests in tests/; you'll need to adapt the pytests.ini.
Also, there are about a hundred tests left in aiida
https://github.com/aiidateam/aiida-core/pull/3715/checks?check_run_id=392973225
Do you want to move them in a separate PR?
Thanks for the review
Yup, forgot to change this. I will also add an explicit path in
No, I forgot about those and will add them here. |
This will prevent them from being included in the distribution that is uploaded to PyPI making the download a lot quicker. Note that this commit only moves the files without touching them. This means that the tests won't actually run since, for example, various imports are broken. For clarity these changes will be done in a following commit to not drown out the important changes between files that were just moved around. Note that the `django` and `sqlachemy` modules in `tests/backend`, which contain backend specific tests, are prefixed with `aiida_`, otherwise imports using either `from django` or `from sqlalchemy` will target incorrectly those modules, instead of the actual libraries.
sphuber
force-pushed
the
fix_3659_move_tests
branch
from
ebc1293
to
68d7fe2
Compare
The unit tests that were moved in the previous commit often imported utilities from a module that used to be located in the main package `aiida.backends.tests.utils`. This module has also been moved to the `tests` top level module. These utilities should really in most cases become pytest fixtures but that is left for a later time.
sphuber
force-pushed
the
fix_3659_move_tests
branch
from
68d7fe2
to
c5bbe09
Compare
There was a problem hiding this comment.
Thanks @sphuber - I've looked through all changed files (wasn't too long after all) and it looks fine.
Also checked that number of tests on django & sqla (python 3.7) are the same as before.
Looks fine to me!
I suggest you change the title since you move all unit tests, not just the ones in backends.
All that remains is a minor update here: https://github.com/aiidateam/aiida-core/wiki/Writing-tests#running-existing-tests
sphuber
changed the title
aiida.backends.tests to top-level testsaiida to top-level tests
Done
I will see if I find sometime to adapt it. There is quite some stuff there that was already outdated even unrelated to this PR. |
|
I've adapted the wiki now to the changed test location. One thing I noticed now is that you changed the folder structure for the transport tests, i.e. the plugin-specific tests are no longer in a subfolder |
Fixes #3659
I have split the work in two commits to make inspecting the changes as easy as possible.
aiidatotests. Besides adapting the.pre-commit-config.yamlthis commit does not contain anything else and should not have to be inspected.Note that the solution of relative imports that I used is an ugly one I find. Most of the existing utilities can be cleaned up and be turned into pytest fixtures. However, I want to keep this for a separate PR.