-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build docker image based on aiida-prerequisites #3722
Conversation
For the record, this is an implementation of the discussion on the plugin testing infrastructure from the coding week (document now frozen). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @yakutovicha !
one comment + please add a job to build the docker file here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
Btw, I think it totally makes sense to move the whole profile setup to quicksetup. What do you guys think? |
@sphuber can you help me in setting up Git Hub actions? I am not sure how to do things right. The manual suggests making a new action file. Is it the way to go? |
What is it that needs to be run and when? Every commit? Take a look at the |
The build of the docker image should be run on every commit |
It should be docker build, yes, it should be run every commit.
I did it, and the check that I've added have failed. https://github.com/aiidateam/aiida-core/pull/3722/checks?check_run_id=405089491 |
You are not installing with |
btw, another option would be to add Docker hub status check. That requires no setup here. What do you guys think? |
Let's try. I wasn't sure if it is allowed to use sudo here.
By default, it takes it from the current folder. I hope the current folder here is the package's root. |
I think that is a good idea. We should not require it to pass, since I believe this can take some time. But it's good to take burden away from github actions, and the build on dockerhub will be needed anyhow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @yakutovicha !
Looks all good to me - the requests are just typos etc.
Co-Authored-By: Leopold Talirz <leopold.talirz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates @yakutovicha !
I notice two issues with the actions build:
- It seems like there is no profile configured, although by your default there should be
- The docker build did not fail despite no profile being configured. I guess you should replace the
verdi profile list
by averdy profile show default
I think I know why let me try to fix that. |
Should be fixed with that: aiidateam/aiida-prerequisites#6. Let's see... |
* Use `wait-for-services` script to wait till all scripts in /etc/my_init.d executed. * Replace `verdi profile list` with `verdi provile show default`
Co-Authored-By: Leopold Talirz <leopold.talirz@gmail.com>
Co-Authored-By: Leopold Talirz <leopold.talirz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @yakutovicha ! From my side this is good to go.
@sphuber : Somehow it looks to me like every actions check ran twice (not jenkins)
Not sure whether this is expected - anyhow I don't see how this PR should be responsible for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yakutovicha almost there: just two small fixes and a suggestion
Oh and one final question: why is the |
It is sort of a convention in that this is the place where many external tools/services will look for the |
@sphuber if you want to merge the PR, please let me know 5 mins in advance: I will set up automated builds on Docker Hub. |
OK this is good to go, let me know when you have setup Docker Hub and I will merge |
ready, please merge. Docker build should now be triggered automatically at Docker Hub: https://hub.docker.com/repository/docker/aiidateam/aiida-core |
Thanks @yakutovicha |
fixes #3725