Improving SSH configuration defaults #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `look_for_keys` is now set to `True` by default (it's also paramiko's default) - `allow_agent` is now set to `True` by default (on the shell, if you have a SSH agent, you expect that it is automatically used by ssh) - If an empty string is passed as the key_filename, this is not passed to paramiko, so it will search for it rather than complaining that file `''` does not exist. Fixes aiidateam#4054
|
Not sure how to write a test for this - this would need to make many assumptions on how the SSH keys are setup in the test machine (and this can be different on each person's computer), etc. But I think that the change makes sense so maybe it's ok to merge even without explicit (additional) tests, w.r.t. those we already have? |
Codecov Report
@@ Coverage Diff @@
## develop #4055 +/- ##
===========================================
+ Coverage 70.49% 78.45% +7.96%
===========================================
Files 461 461
Lines 34077 34079 +2
===========================================
+ Hits 24020 26733 +2713
+ Misses 10057 7346 -2711
Continue to review full report at Codecov.
|
sphuber
approved these changes
May 6, 2020
There was a problem hiding this comment.
Thanks @giovannipizzi . I agree that this doesn't require a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
look_for_keysis now set toTrueby default(it's also paramiko's default)
allow_agentis now set toTrueby default (on the shell,if you have a SSH agent, you expect that it is automatically
used by ssh)
to paramiko, so it will search for it rather than complaining that
file
''does not exist.Fixes #4054