Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default ssh configuration of computers #4054

Closed
giovannipizzi opened this issue May 6, 2020 · 0 comments · Fixed by #4055
Closed

Improve default ssh configuration of computers #4054

giovannipizzi opened this issue May 6, 2020 · 0 comments · Fixed by #4055

Comments

@giovannipizzi
Copy link
Member

Currently, during computer configure, the look_for_keys is set to False by default. Better to set it to True (paramiko's default). Also, I would set allow_agent to True (on the shell, if you have a SSH agent, you expect that it is automatically used by ssh).
Finally, if no key is specified (empty string), this should just not be passed to paramiko. Currently, during a verdi computer test, I get an error

[SshTransport] [Errno 2] No such file or directory: '', connect_args were: {
'gss_host': 'daint.cscs.ch', 
'port': 22, 
'look_for_keys': True, 
'timeout': 60, 
'gss_deleg_creds': False, 
'compress': True, 
'username': 'pizzi', 
'sock': <aiida.transports.util._DetachedProxyCommand object at 0x7f0251adaa20>, 
'gss_auth': False, 
'key_filename': '', 
'allow_agent': True, 
'gss_kex': False
}
@giovannipizzi giovannipizzi self-assigned this May 6, 2020
giovannipizzi added a commit to giovannipizzi/aiida-core that referenced this issue May 6, 2020
- `look_for_keys` is now set to `True` by default
  (it's also paramiko's default)
- `allow_agent` is now set to `True` by default (on the shell,
  if you have a SSH agent, you expect that it is automatically
  used by ssh)
- If an empty string is passed as the key_filename, this is not passed
  to paramiko, so it will search for it rather than complaining that
  file `''` does not exist.

Fixes aiidateam#4054
@sphuber sphuber added topic/computers topic/verdi type/accepted feature approved feature request and removed type/feature request status undecided labels May 6, 2020
@sphuber sphuber added this to the v1.2.2 milestone May 20, 2020
@sphuber sphuber modified the milestones: v1.2.2, v1.3.0 Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants