✨ NEW: structure.data.import plugin entrypoint

[dev-zero]

The use case is that I would like to add an option to import structures from a CP2K input file.
While this could be done in an aiida-cp2k cli or an extension of verdi data, it would make more sense to add it directly here.
On the other hand it might not be a good idea to open up too many entry points since we would have to maintain those.

[codecov]

Codecov Report

Merging #4427 (3b5c0dc) into develop (a6be2a2) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #4427      +/-   ##
===========================================
+ Coverage    79.52%   79.54%   +0.02%     
===========================================
  Files          519      519              
  Lines        37087    37088       +1     
===========================================
+ Hits         29490    29497       +7     
+ Misses        7597     7591       -6     

Flag	Coverage Δ
django	74.28% <100.00%> (+0.02%)	⬆️
sqlalchemy	73.19% <100.00%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aiida/plugins/entry_point.py	91.82% <ø> (ø)
aiida/cmdline/commands/cmd_data/cmd_structure.py	84.06% <100.00%> (+0.12%)	⬆️
aiida/cmdline/utils/pluginable.py	92.00% <0.00%> (+24.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6be2a2...3b5c0dc. Read the comment docs.

[ltalirz]

thanks @dev-zero - I see no issue with this and would support it (this would anyhow move outside aiida-core together with the materials-science specific classes, if that ever happens).

Could you please bring the PR up to date?

@chrisjsewell any comments?

[dev-zero]

@ltalirz thanks a lot for the positive feedback, rebased as requested

[ltalirz]

@chrisjsewell I approve this but I'd like one more pair of eyes on this.
Feel free to merge if you agree

[chrisjsewell]

Looks good cheers, but could you add a small bit of documentation of the feature around here thanks: https://github.com/aiidateam/aiida-core/blob/develop/docs/source/topics/plugins.rst#aiidacmdline

[dev-zero]

Looks good cheers, but could you add a small bit of documentation of the feature around here thanks: https://github.com/aiidateam/aiida-core/blob/develop/docs/source/topics/plugins.rst#aiidacmdline

Done. Based on the already existing one with a spec, example and example usage.

[ltalirz]

thanks @dev-zero !

[ltalirz]

@chrisjsewell can you approve & merge?

[chrisjsewell]

cheers!