Fix UnboundLocalError in aiida.cmdline.utils.edit_multiline_template
#4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `click.edit` returns a falsy value, the following conditional would be skipped and the `value` variable would be undefined causing an `UnboundLocalError` to be raised. This bug was reported by @blokhin but the exact conditions under which it occurred are not clear.
Codecov Report
@@ Coverage Diff @@
## develop #4436 +/- ##
===========================================
- Coverage 79.36% 79.36% -0.00%
===========================================
Files 476 476
Lines 34950 34950
===========================================
- Hits 27734 27733 -1
- Misses 7216 7217 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I find one occurrence of this error, that is when setup a computer: when verdi asks for |
|
@chrisjsewell and @ramirezfranciscof this has been open for a while and needs to go in the next release. Would be good if any you two can review it. |
chrisjsewell
approved these changes
Oct 26, 2020
sphuber
added a commit
that referenced
this pull request
Nov 6, 2020
…te` (#4436) If `click.edit` returns a falsy value, the following conditional would be skipped and the `value` variable would be undefined causing an `UnboundLocalError` to be raised. This bug was reported by @blokhin but the exact conditions under which it occurred are not clear. Cherry-pick: 861a39f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4435
If
click.editreturns a falsy value, the following conditional wouldbe skipped and the
valuevariable would be undefined causing anUnboundLocalErrorto be raised. This bug was reported by @blokhin butthe exact conditions under which it occurred are not clear.