-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine: implement sub-dicts for context in workchains #4871
Conversation
@sphuber as discussed on Slack.
|
also, I checked the codebase for other erroneous uses of |
Codecov Report
@@ Coverage Diff @@
## develop #4871 +/- ##
===========================================
+ Coverage 80.05% 80.09% +0.04%
===========================================
Files 515 515
Lines 36611 36626 +15
===========================================
+ Hits 29307 29333 +26
+ Misses 7304 7293 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
93db3db
to
cf7a823
Compare
cf7a823
to
422a6c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @dev-zero . Overall I fully support the feature and implementation, just some minor comments. Also, it would be important to document this feature. I would suggest adding this to this section: https://aiida.readthedocs.io/projects/aiida-core/en/latest/topics/workflows/usage.html?highlight=append_#to-context
b60df9e
to
874e018
Compare
Incidentally, this also fixes an issue where no exceptions were raised for either unknown awaitable actions or awaitable mismatches for lists of awaitables since an `assert "some str"` is always True (hence never triggers).
874e018
to
38da950
Compare
done |
Thanks a lot @dev-zero |
Fixes #4972