DirectScheduler: use num_cores_per_mpiproc if defined in resources
#5126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `num_cores_per_mpiproc` is specified in the job resources, the value will now be exported as the `OMP_NUM_THREADS` variable. Co-Authored-By: Sebastiaan Huber <mail@sphuber.net>
Codecov Report
@@ Coverage Diff @@
## develop #5126 +/- ##
===========================================
+ Coverage 80.82% 80.83% +0.02%
===========================================
Files 534 534
Lines 36946 36951 +5
===========================================
+ Hits 29857 29865 +8
+ Misses 7089 7086 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Merging this myself without approval. It was already approved by @giovannipizzi in #5051 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
num_cores_per_mpiprocis specified in the job resources, the valuewill now be exported as the
OMP_NUM_THREADSvariable.Supersedes #5051