Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Specify abstract methods on Transport #5242

Merged
merged 3 commits into from
Dec 6, 2021

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Dec 3, 2021

Replace raise NotImplementedError with proper @abc.abstractmethod decorators

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #5242 (abf315b) into develop (eb73c7d) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5242      +/-   ##
===========================================
+ Coverage    81.31%   81.38%   +0.07%     
===========================================
  Files          529      529              
  Lines        37031    37008      -23     
===========================================
+ Hits         30109    30116       +7     
+ Misses        6922     6892      -30     
Flag Coverage Δ
django 76.85% <100.00%> (+0.05%) ⬆️
sqlalchemy 75.83% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/transports/transport.py 78.29% <100.00%> (+11.77%) ⬆️
aiida/transports/plugins/local.py 81.41% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb73c7d...abf315b. Read the comment docs.

@chrisjsewell chrisjsewell merged commit e3651e0 into aiidateam:develop Dec 6, 2021
@chrisjsewell chrisjsewell deleted the transport-abstract branch December 6, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants