DirectScheduler: remove the -e option for bash invocation
#5264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scheduler implementation was submitting the submit script using bash with the `-e` option. This flags toggles the behavior that bash will exit the script as soon as any of the commands in the script return a non-zero exit code. This is in contrast with most (if not all) other implementations that will continue running the script. This is for a good reason, because often there are critical lines in the rest of the script that need to be executed for cleanup. For example, with the current state, if the main executable returns with a non-zero exit code, the script would exit, and any lines that were added through the `append_text` of either the `Computer` or the `Code` will be skipped. Therefore, we remove the `-e` flag, which technically changes the behavior, but it is very unlikely that any clients were relying on particular parts of the submit script to not be executed in case of an error.
Codecov Report
@@ Coverage Diff @@
## develop #5264 +/- ##
========================================
Coverage 81.42% 81.42%
========================================
Files 529 529
Lines 37002 37002
========================================
Hits 30127 30127
Misses 6875 6875
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ltalirz
pushed a commit
that referenced
this pull request
Feb 17, 2022
The scheduler implementation was submitting the submit script using bash with the `-e` option. This flags toggles the behavior that bash will exit the script as soon as any of the commands in the script return a non-zero exit code. This is in contrast with most (if not all) other implementations that will continue running the script. This is for a good reason, because often there are critical lines in the rest of the script that need to be executed for cleanup. For example, with the current state, if the main executable returns with a non-zero exit code, the script would exit, and any lines that were added through the `append_text` of either the `Computer` or the `Code` will be skipped. Therefore, we remove the `-e` flag, which technically changes the behavior, but it is very unlikely that any clients were relying on particular parts of the submit script to not be executed in case of an error. Cherry-pick: 29915bd
|
@sphuber Just fyi, I cherry-picked this into If we still plan to push out a 1.6.6 release, we should definitely include this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5229
The scheduler implementation was submitting the submit script using bash
with the
-eoption. This flags toggles the behavior that bash willexit the script as soon as any of the commands in the script return a
non-zero exit code.
This is in contrast with most (if not all) other implementations that
will continue running the script. This is for a good reason, because
often there are critical lines in the rest of the script that need to be
executed for cleanup. For example, with the current state, if the main
executable returns with a non-zero exit code, the script would exit, and
any lines that were added through the
append_textof either theComputeror theCodewill be skipped.Therefore, we remove the
-eflag, which technically changes thebehavior, but it is very unlikely that any clients were relying on
particular parts of the submit script to not be executed in case of an
error.