✨ NEW: Allow for CLI usage via python -m aiida

[chrisjsewell]

This allows for advanced use-cases, where one may wish to directly specify the python interpreter to use.

$ python -m aiida
Usage: python -m aiida [OPTIONS] COMMAND [ARGS]...

  The command line interface of AiiDA.

Options:
  -p, --profile PROFILE           Execute the command for this profile instead
                                  of the default profile.
  -v, --verbosity [notset|debug|info|report|warning|error|critical]
                                  Set the verbosity of the output.
  --version                       Show the version and exit.
  --help                          Show this message and exit.

Commands:

[chrisjsewell]

Not sure if/how we want to add a test 🤷

[sphuber]

Not sure if/how we want to add a test shrug

You could add a simple test in the tests.sh bash script that calls python -m aiida and checks that the return exit code is 0 and the content printed to stdout contains Usage: python -m aiida [OPTIONS] COMMAND [ARGS]... for example. Should be enough no?

[chrisjsewell]

Should be enough no?

yeh, might as well 👍

[csadorf]

Great! I'm also in favor of adding a basic smoke test for this.

[chrisjsewell]

Added the test to verdi.sh

[csadorf]

Why not just exit 2 here as well? Is there a reason for forwarding the exit code from the test script? Seems slightly unexpected to me.

[chrisjsewell]

Well my thinking was that the 2nd check, of the stdout, should also run, even if the exit code is not 0

[csadorf]

Why? But even so, I would still exit 2 on any failure. It just seems unintuitive to me that the test script would forward the exit code unless explicitly requested.

[chrisjsewell]

changed it

[sphuber]

All good, just small change on variable style consistency and I would suggest to actually print some output even if all goes well. This will allow to check the logs and verify that something was actually run. Now we don't see any evidence of this check having been run

[sphuber]

Uhm @chrisjsewell this may have been my mistake in the review suggestion, but there is a type here. If I promise to not merge your PRs anymore, will you promise to let me sign off on them first :)

[chrisjsewell]

Doh, thats all your fault 😅

[sphuber]

Don't worry, I have a small PR coming up with some minor corrections that I can put this in as well

[chrisjsewell]

cheers!