Not prompt memory set for core.direct

[unkcpz]

The warning Warning: Physical memory limiting is not supported by the direct scheduler. pop up if set the computer by interactive mode.
The default_memory_per_machine should not pop up from computer setup with core.direct scheduler.

But I am not sure where to add the unit test for this.

[sphuber]

Thanks @unkcpz . As for the testing, I would add it to tests/cmdline/commands/test_computer.py. Run a setup command with --scheduler-type=core.direct and make sure that the warning from the DirectJobResource is not printed. There might be a more robust way that would monkeypatch either the option or the command to raise when it is called or the option is specified in the command.

[sphuber]

I realize that the existing method accepts_default_mpiprocs_per_machine is abstract, but I think in this case it is better to just implement it on the base class. Currently, the code behaves as is the default is True, so I would just return that here. Then you can simply update the DirectJobResource to return False. This way, we don't risk breaking other JobResource implementations out there that all of a sudden would no longer be concrete.

[unkcpz]

Fully agree, the potential risk you mentioned is true, I found I missing to implement the abstract method to TemplateJobResource.

[sphuber]

This actually doesn't match the behavior. If job_resource_cls is None then it returns False. If the scheduler class cannot be determined, I think it is best to return False, because in that case the option won't be prompted and the user might just have to configure it manually afterwards. If we return True and the scheduler doesn't actually support it, then any CalcJobs that will be run with it, will fail I believe.

So I think the code is correct and should be kept, but the docstring should be updated (see other comments what I suggest).

[sphuber]

Suggested change

	"""
	Return True if the scheduler can accept 'default_memory_per_machine',
	False otherwise.
	If there is a problem in determining the scheduler, return True to
	avoid exceptions.
	"""
	"""Return whether the selected scheduler type accepts `default_memory_per_machine`.
	:return: `True` if the scheduler type accepts `default_memory_per_machine`, `False` otherwise. If the scheduler class could not be loaded `False` is returned by default.
	"""

[sphuber]

Idem dito for the should_call_default_mpiprocs_per_machine docstring.

[unkcpz]

@sphuber thanks! I add the test in tests/cmdline/commands/test_computer.py change the test name from test_interactive to test_direct_interactive and pop the unused default-memory-per-machine from the options list.
The test passes with the current implementation as expectation and fails the previous which stuck at asking for the default-memory-per-machine.

[sphuber]

@unkcpz if you fix the tests and docs, I will give another review

[sphuber]

thanks @unkcpz

[unkcpz]

Thanks @sphuber, I forget to request for your review again 😆