Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process control: Reinstate process status for paused/killed processes #5754

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Nov 10, 2022

The recent commit 8bb7b34 accidentally removed the process_status being set on nodes when they were being paused or killed through verdi process pause/kill.

This behavior is reinstated with tests to prevent future regression. The process status is now also set when done directly through the Python API.

The recent commit 8bb7b34 accidentally
removed the `process_status` being set on nodes when they were being
paused or killed through `verdi process pause/kill`.

This behavior is reinstated with tests to prevent future regression. The
process status is now also set when done directly through the Python API.
Copy link
Member

@ramirezfranciscof ramirezfranciscof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sphuber sphuber merged commit 530a724 into aiidateam:main Nov 10, 2022
@sphuber sphuber deleted the fix/process-status-on-kill-pause branch November 10, 2022 10:25
@sphuber sphuber mentioned this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants