CLI: Improved customizability and scriptability of verdi storage maintain

[Crivella]

Introduced changes

This pull requests, adds 2 option to verdi storage maintain:

• --no-repack: disables the do_repack option when running a full maintenance with the DiskObjectStore backend.
• --yes or -y: skip the confirmation prompt to use command in scripts (eg periodic maintenance with CRON)

Not using the flags leave the behavior of the command unaltered for back-compatibility

Reasoning

When performing a storage maintenance operation through the verdi CLI, the only two available options right now is to do either a live or non live operation.

Using the DiskObjectStore backend this translates to doing one of the 2:

• pack_all_loose only, which store all loose files inside packs, but does not remove the loose files itself.
• pack_all_loose, do_repack, clean_storage, vacuum

I think it would be useful to have a more granular control of the live maintain operation.
Especially the do_repack option can be undesired, when performing maintenance on a huge repository that is being backed up via rsync. Instead, performing the clean_storage periodically is almost mandatory for having efficient backups. Without it we end-up in the same situation as the old storage of having a huge amount of IO nodes to rsync, plus the redundancy of having both the loose and packed version of a file if verdi storage maintain is being run periodically.

[ltalirz]

hey @Crivella, just checking: have you talked to anyone from the AiiDA team about this already who might be able to review this PR?

[Crivella]

Hi @ltalirz, I got in touch with @chrisjsewell on slack last week, he said he should give it a look this week.

[chrisjsewell]

great cheers!

[sphuber]

Thanks @Crivella , useful addition. I was just wondering if we could have better used the --force option instead of --yes. The --force option is used consistently across verdi to skip prompts. Introducing a new option (--yes is not used anywhere as far as I know) reduces consistency. Do you agree @chrisjsewell and @Crivella ? If so, I can quickly open a PR to address that.

[Crivella]

Hi @sphuber I am not against it. Sorry, didn't notice that --force was already used when i grepped since it was hidden in the OverridableOption