Fix recreation of stepper in workchain 'if' logical block #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a mistake in the logic of the 'if' block of workchains when loading. A position varaiable was being used to keep track of how many times that conditional block was ticked. This was being upped each time but also being used to determine which of possible conditional branches the condition was at e.g.: if(...)( <-- pos 0 ) elif(...) <-- pos 1 ) else( ) Long story short, when the condition was reloaded from a saved state it was possible that pos was larger than the number of conditions (usual just one if there's only an if) and it couldn't resume from where it was when it was saved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mistake in the logic of the 'if' block of workchains when
loading. A position varaiable was being used to keep track of how many
times that conditional block was ticked. This was being upped each
time but also being used to determine which of possible conditional
branches the condition was at e.g.:
Long story short, when the condition was reloaded from a saved state
it was possible that pos was larger than the number of conditions
(usual just one if there's only an if) and it couldn't resume
from where it was when it was saved.