Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 981. #982

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Fix 981. #982

merged 1 commit into from
Dec 11, 2017

Conversation

greschd
Copy link
Member

@greschd greschd commented Dec 8, 2017 •
edited
Loading

This PR replaces os.rename with shutil.move to fix #981. Also needs changing in plumpy.

@sphuber, which plumpy branch should I commit this to?

@greschd greschd requested a review from sphuber December 8, 2017 23:52
@greschd greschd changed the title Replace 'os.rename' with 'shutil.move', to allow cross-device moving [WIP] Fix 981. Dec 8, 2017
@greschd greschd changed the title [WIP] Fix 981. Fix 981. Dec 9, 2017
@sphuber
Copy link
Contributor

sphuber commented Dec 11, 2017

Probably best to PR into event_loop branch

@sphuber sphuber merged commit f7f55ce into aiidateam:develop Dec 11, 2017
@greschd
Copy link
Member Author

greschd commented Dec 11, 2017 •
edited
Loading

The event_loop branch no longer uses os.rename -- so I guess that's fixed already 🙂.

@greschd greschd deleted the fix_981_use_shutil_move branch June 12, 2018 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphuber sphuber sphuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pickles cannot be created on a different hard drive
2 participants
@greschd @sphuber