Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: info update to conform with latest aiida-core #16

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Apr 30, 2024

minor changes in documentation.

  • ssh -> core.ssh
  • In eiger it has the new scratch folder path.
  • Update the hq latest version for download.

@unkcpz unkcpz requested a review from mbercx April 30, 2024 14:09
Copy link
Member

@mbercx mbercx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @unkcpz! I've left some comments.

pyproject.toml Outdated
@@ -4,7 +4,7 @@ build-backend = "flit_core.buildapi"

[project]
name = "aiida-hyperqueue"
version = "0.1.0"
version = "0.1.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:::

For the older version of HyperQueue, you can change the version number in the URL.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, since some changes might rely on a more recent hyperqueue version, I'd stick with the version I've tested (v0.16.0). Unless you've tested it for other versions, but I'm quite sure for some versions it will break.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test it from 0.16 ~ 0.19. The 0.18.0 should be a suggested one, since they drop hq dashboard for the moment (It4innovations/hyperqueue#725)

@unkcpz unkcpz marked this pull request as draft May 2, 2024 08:31
pyproject.toml Outdated Show resolved Hide resolved
@unkcpz unkcpz marked this pull request as ready for review July 17, 2024 12:37
@unkcpz unkcpz requested a review from mbercx July 17, 2024 12:37
@unkcpz unkcpz merged commit 422b61d into aiidateam:main Jul 18, 2024
3 checks passed
@unkcpz unkcpz deleted the doc/minor-fixes branch July 18, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants